Fix string escape in @as("foo") on argument of externals. #5446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) change files by hand 2) touch js_fold.ml js_record_iter.ml js_record_map.ml js_record_fold.ml
cknitt
approved these changes
Jun 19, 2022
cristianoc
changed the title
cristianoc
changed the title
mununki
pushed a commit
to mununki/rescript-compiler
that referenced
this pull request
Jul 15, 2022
…ang#5446) * emit str * Hack timestamps to get around tree-sitter failing on M1. 1) change files by hand 2) touch js_fold.ml js_record_iter.ml js_record_map.ml js_record_fold.ml * Do not escape strings in @bs.as on externals. Fixes rescript-lang#5402 * Hack the timestamp by doing a dummy modification. * Comments in code. * An alternative solution that requires fewer changes. * Remove changes to Str. * Restore original files. * More restore files. * Comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.